Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cmake & ninja build requirements only when needed #2451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add cmake & ninja build requirements only when needed #2451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/vaex-core/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,4 @@ requires = [
"oldest-supported-numpy; python_version=='3.8'", # deprecated ref https://github.com/scipy/oldest-supported-numpy
"numpy~=1.25; python_version>'3.8'", # numpy~=2.0 fails, backward compatible build-system as of v1.25 ref https://numpy.org/doc/2.1/dev/depending_on_numpy.html#build-time-dependency
"scikit-build",
"cmake",
"ninja"
]
6 changes: 6 additions & 0 deletions packages/vaex-core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from setuptools import setup
import shutil
import sys
import os
from importlib.machinery import SourceFileLoader
Expand All @@ -25,6 +26,11 @@
url = "https://www.github.com/maartenbreddels/vaex"
# TODO: after python2 supports frops, future and futures can also be dropped
setup_requires = ["numpy~=1.17"]
if use_skbuild:
if not shutil.which("cmake"):
setup_requires += ["cmake"]
if not shutil.which("ninja"):
setup_requires += ["ninja"]
install_requires_core = [
"numpy~=1.17",
"aplus",
Expand Down
Loading