Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Ultravox Model: Support v0.5 Release #12912

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

farzadab
Copy link

@farzadab farzadab commented Feb 7, 2025

Hi there!

We (cc @petersalas) are preparing for the v0.5 release of Ultravox audio/text to text model. This release does some minor adjustments to the architecture (moves a layer norm before the last layer of the projector).
The previous versions are still supported through the config parameter projector_ln_mid.

I'm gonna mark this as draft for now until I can verify everything. I'm also gonna add a test for v0.5 going forward once it becomes public.

Copy link

github-actions bot commented Feb 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@farzadab farzadab marked this pull request as draft February 7, 2025 17:44
@farzadab farzadab force-pushed the farzad-ultravox-v05 branch from ec6e6c0 to 35c3e17 Compare February 7, 2025 17:50
@ywang96 ywang96 self-assigned this Feb 7, 2025
@ywang96
Copy link
Member

ywang96 commented Feb 7, 2025

@farzadab @petersalas Thanks for the contribution! Feel freel to ping me here or on slack whenever this is ready for review!

@petersalas
Copy link
Contributor

I'm also gonna add a test for v0.5 going forward once it becomes public.

I suspect we should probably just update the test to use the newest model (after smoke testing that the new code still works on 0.3 and 0.4.1)? And maybe switch to using the 1B model as long as it can demonstrate some understanding of the sample audios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants