-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: online checker #1125
feat: online checker #1125
Conversation
Jenkins BuildsClick to see older builds (8)
|
a88a477
to
7174378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we had already addressed this, but looks like it is not.
e3bfcc1
to
ffabc2b
Compare
@chaitanyaprem what do you think of this proposal?
and use the option |
ffabc2b
to
839df15
Compare
I do see however that in status-go, being online in the FilterManager has a different handling initially, so I'll add a function to be able to override the onlineChecker for filter. |
ac600b0
to
b9d764b
Compare
b9d764b
to
8724fcb
Compare
8724fcb
to
31ae379
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Allows consumers of the library to setup the node online/offline state