Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: online checker #1125

Merged
merged 4 commits into from
Jun 25, 2024
Merged

feat: online checker #1125

merged 4 commits into from
Jun 25, 2024

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Jun 12, 2024

Description

Allows consumers of the library to setup the node online/offline state

@status-im-auto
Copy link

status-im-auto commented Jun 12, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a88a477 #1 2024-06-12 18:20:27 ~1 min nix-flake 📄log
✔️ 7174378 #2 2024-06-12 19:14:08 ~2 min nix-flake 📄log
✔️ e3bfcc1 #3 2024-06-18 18:36:12 ~1 min nix-flake 📄log
✔️ ffabc2b #4 2024-06-18 18:41:34 ~1 min nix-flake 📄log
✔️ 839df15 #5 2024-06-18 18:44:41 ~1 min nix-flake 📄log
✔️ ac600b0 #6 2024-06-18 18:50:32 ~2 min nix-flake 📄log
✔️ b9d764b #7 2024-06-18 19:15:08 ~1 min nix-flake 📄log
✔️ 8724fcb #8 2024-06-19 18:49:10 ~1 min nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 31ae379 #9 2024-06-19 19:08:26 ~1 min nix-flake 📄log
✔️ 2d7ff42 #10 2024-06-25 12:44:09 ~1 min nix-flake 📄log

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had already addressed this, but looks like it is not.

waku/v2/node/wakunode2.go Outdated Show resolved Hide resolved
waku/v2/peermanager/peer_connector.go Outdated Show resolved Hide resolved
@richard-ramos richard-ramos changed the title feat: pause peer connector feat: online checker Jun 18, 2024
@richard-ramos
Copy link
Member Author

@chaitanyaprem what do you think of this proposal?
In status-go we should have to implement a

type OnlineChecker interface {
	IsOnline() bool
}

and use the option WithOnlineChecker(myOnlineChecker) when setting up the node.

@richard-ramos
Copy link
Member Author

I do see however that in status-go, being online in the FilterManager has a different handling initially, so I'll add a function to be able to override the onlineChecker for filter.

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit ee33baa into master Jun 25, 2024
11 of 12 checks passed
@richard-ramos richard-ramos deleted the pause/connector branch June 25, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants