Fix attribute formatting from running erb-lint #269
Conversation
jrussell416
changed the title
.gitignore
Outdated
| # ERB Lint binaries | ||
| echo "bin/erb-lint" >> .gitignore | ||
| echo "bin/erb_lint" >> .gitignore | ||
| echo "bin/erblint" >> .gitignore |
There was a problem hiding this comment.
I think I would just add the erb lint filenames directly, rather than going via echo
| <%= yield %> | ||
| <div id="root" class="min-w-full"> | ||
| <div id="root" class="min-w-full"></div> |
| @@ -0,0 +1 @@ | |||
| /home/jennifer/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/erb_lint-0.8.0/exe/erb_lint | |||
There was a problem hiding this comment.
This feels like it should not be checked in with your path in it
|
Reviewing the conflicts, I realized that the underlying issue was related to the binstub setup on my local. Running However, this approach inadvertently caused issues with the bin directory and .gitignore. Now that I’ve resolved the binstub problem, I’ll redo this PR with a cleaner approach to ensure consistency moving forward. Closing this PR to open a new one with the correct fixes. |
This PR addresses formatting issues identified after implementing the ERB linter in #264, which was introduced to address #175.
This fix added quotes around attribute value
Before
After
During PR tests, RuboCop flagged some offenses related to bin/erb and StringLiterals. . These issues were fixed using RuboCop's --auto-correct option to ensure the PR passes all tests.