Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute formatting from running erb-lint #269

Closed
wants to merge 6 commits into from
Closed

Fix attribute formatting from running erb-lint #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9f8d9d9
add quotes to class attribute in <body> tag
jrussell416 Feb 3, 2025
b12d3d7
add erb-lint binaries to .gitignore
jrussell416 Feb 3, 2025
c8f9e90
stop tracking erb-lint binaries and add them to .gitignore
jrussell416 Feb 3, 2025
d33e718
add quotes to class attribute in <body> tag
jrussell416 Feb 3, 2025
3d571f2
Fix RuboCop offenses in bin/erb_lint and bin/erblint
jrussell416 Feb 4, 2025
2b49e54
add erb lint binaries
jrussell416 Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,9 @@ google-credentials.json

# Ignore asdf version file
.tool-versions

# ERB Lint binaries
bin/erb-lint
bin/erb_lint
bin/erblint

4 changes: 2 additions & 2 deletions app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
</head>
<%- body_class = 'admin' if controller_name == 'sessions' %>

<body class=<%= body_class %>>
<body class='<%= body_class %>'>
<%= yield %>
<div id="root" class="min-w-full">
<div id="root" class="min-w-full"></div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, thanks!

</body>

</html>
1 change: 1 addition & 0 deletions bin/erb-lint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/home/jennifer/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/erb_lint-0.8.0/exe/erb_lint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it should not be checked in with your path in it

27 changes: 27 additions & 0 deletions bin/erb_lint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#!/usr/bin/env ruby
# frozen_string_literal: true

#
# This file was generated by Bundler.
#
# The application 'erb_lint' is installed as part of a gem, and
# this file is here to facilitate running it.
#

ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)

bundle_binstub = File.expand_path('bundle', __dir__)

if File.file?(bundle_binstub)
if File.read(bundle_binstub, 300).include?('This file was generated by Bundler')
load(bundle_binstub)
else
abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
end
end

require 'rubygems'
require 'bundler/setup'

load Gem.bin_path('erb_lint', 'erb_lint')
27 changes: 27 additions & 0 deletions bin/erblint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#!/usr/bin/env ruby
# frozen_string_literal: true

#
# This file was generated by Bundler.
#
# The application 'erblint' is installed as part of a gem, and
# this file is here to facilitate running it.
#

ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)

bundle_binstub = File.expand_path('bundle', __dir__)

if File.file?(bundle_binstub)
if File.read(bundle_binstub, 300).include?('This file was generated by Bundler')
load(bundle_binstub)
else
abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
end
end

require 'rubygems'
require 'bundler/setup'

load Gem.bin_path('erb_lint', 'erblint')