force totalCount to be FALSE #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
approved these changes
Jan 31, 2019
| { | ||
| /** `totalCount` is calculated after the request */ | ||
| if (!empty($config['pagination'])) { | ||
| $config['pagination']['totalCount'] = false; |
There was a problem hiding this comment.
Should be mentioned that obtaining count is a cheap operation in ElasticSearch so it makes sense to always calculate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more way to fix the issues. In my opinion @grozzzny offer the best solution, due to we don't need change
BaseDataProvider::_paginationscope.