Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset and Dataset member allocation via ZSS API #351

Open
wants to merge 7 commits into
base: v1.x/staging
Choose a base branch
from

Conversation

timgerstel
Copy link
Contributor

@timgerstel timgerstel commented Sep 23, 2021

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

This PR depends upon the following PRs:

zowe/zowe-common-c#244

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Tim Gerstel added 6 commits September 23, 2021 19:14
Signed-off-by: Tim Gerstel <[email protected]>
Signed-off-by: Tim Gerstel <[email protected]>
Signed-off-by: Tim Gerstel <[email protected]>
Signed-off-by: Tim Gerstel <[email protected]>
Signed-off-by: Tim Gerstel <[email protected]>
Copy link
Contributor

@lchudinov lchudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantically, POST is more suitable for creating datasets, and PUT for updating. But it seems too late to change the API, so I approve the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants