Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-on-gke part 5] Support per-workload gcsfuse-mount-options and other improvements #2348

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Aug 14, 2024

Description

This adds the following changes

  1. Now, gcsfuse_mount_options is no longer taken on the run-gke-tests.sh script, and is instead taken per workload in the ${workload_config} file. Sample at
    "gcsfuseMountOptions": "implicit-dirs",
    ) .
  2. helm chart names and pod names have been shortened by using a hash of the workload rather than the long names earlier used which encapsulated the workload parameters such as blockSize/numThreads/batchSize etc. It still keeps the name of the scenario and file-size in the pod/chart name for some information for easy spotting though.
  3. Adds validation checks and unit tests for dlio_workload and fio_workload.

This is on top of #2329 . It is followed up in #2482.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle changed the base branch from master to garnitin/add-gke-load-testing/add-run-script/v2 August 14, 2024 04:38
@gargnitingoogle gargnitingoogle marked this pull request as ready for review August 14, 2024 04:39
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners August 14, 2024 04:39
@gargnitingoogle gargnitingoogle requested review from sethiay and removed request for a team August 14, 2024 04:39
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (9209696) to head (32b31ba).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2348      +/-   ##
==========================================
- Coverage   78.88%   78.82%   -0.06%     
==========================================
  Files         106      106              
  Lines       11686    11686              
==========================================
- Hits         9219     9212       -7     
- Misses       1989     1997       +8     
+ Partials      478      477       -1     
Flag Coverage Δ
unittests 78.82% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from b292b8e to 867f50f Compare August 14, 2024 10:48
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from 21b6604 to 792a7c7 Compare August 14, 2024 10:49
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 61f2418 to b201e4e Compare August 19, 2024 07:22
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch 2 times, most recently from d59bb15 to 87232d8 Compare August 19, 2024 07:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 2fec539 to 2ec75eb Compare August 19, 2024 09:01
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from 87232d8 to afb94d7 Compare August 19, 2024 09:02
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 2ec75eb to a4552be Compare August 19, 2024 15:14
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from afb94d7 to d82bb7f Compare August 19, 2024 15:15
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from a4552be to 04af62c Compare August 20, 2024 05:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from d82bb7f to 57da96f Compare August 20, 2024 05:49
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 04af62c to 0769f9a Compare August 21, 2024 07:35
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from 57da96f to 3bd033b Compare August 21, 2024 07:36
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 0769f9a to c415a6a Compare August 21, 2024 11:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from 3bd033b to d30bc7f Compare August 21, 2024 11:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from c415a6a to acdb534 Compare August 22, 2024 10:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from d30bc7f to 1648935 Compare August 22, 2024 10:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from acdb534 to 8f11904 Compare August 22, 2024 12:54
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from baa90a6 to 4c995cc Compare August 29, 2024 04:21
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from ecdc926 to 9528ea4 Compare August 29, 2024 04:21
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 4c995cc to 4d4393c Compare September 2, 2024 05:26
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch 2 times, most recently from 31c21ec to 98dedc0 Compare September 2, 2024 08:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch 2 times, most recently from 3834b55 to ae680fe Compare September 3, 2024 05:01
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from 98dedc0 to e839011 Compare September 3, 2024 05:01
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from ae680fe to e85ce99 Compare September 3, 2024 07:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from e839011 to 29a4894 Compare September 3, 2024 07:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from e85ce99 to 6725598 Compare September 9, 2024 09:28
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from 29a4894 to 7ae3100 Compare September 9, 2024 09:28
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 6725598 to 8150b1d Compare September 10, 2024 12:22
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch 2 times, most recently from 8fa4484 to bc1bb75 Compare September 10, 2024 12:46
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from 9b50a76 to d29b830 Compare September 16, 2024 02:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from bc1bb75 to 27b69cc Compare September 16, 2024 02:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v2 branch from d29b830 to c93cfac Compare September 17, 2024 07:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from c8a2572 to aed8638 Compare September 17, 2024 07:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/gcsfuse-option-per-workload/v1 branch from aed8638 to 824cf7b Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/add-run-script/v2 to master September 18, 2024 06:25
@gargnitingoogle gargnitingoogle merged commit 0fae307 into master Sep 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants