UI changes to use the renamed product features from core #22971 #9142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jrafanie
changed the title
Merged
6 tasks
jrafanie
commented
Apr 1, 2024
| @@ -1892,7 +1892,8 @@ def controller_for_common_methods | |||
| "embedded_configuration_script_payload" | |||
| when "workflow_repository" | |||
| "ansible_repository" | |||
| # TODO: Update manageiq/db/fixtures/miq_product_features.yml by replacing ansible_credential_tag with embedded_automation_manager_credential_tag | |||
| # DONE: Update manageiq/db/fixtures/miq_product_features.yml by replacing ansible_credential_tag with embedded_automation_manager_credential_tag | |||
| # TODO: This is now done, can we fix this case statement? | |||
There was a problem hiding this comment.
@GilbertCherrie not sure if we can fix this case statement now that we rename this. It was added in 1cc6e74 and treats workflows like ansible repositories..
jrafanie
force-pushed
the
rename_ansible_tag_features_to_be_generic
branch
from
5e08341 to
089b404
Compare
jrafanie
commented
Apr 1, 2024
| # "embedded_automation_manager_credential" | ||
| when "workflow_credential" | ||
| "ansible_credential" | ||
| when "workflow_repository", "ansible_repository" |
There was a problem hiding this comment.
I added ansible_repository to match the pattern we have in the next when:
when "workflow_credential", "ansible_credential"It didn't exist here before. Feel free to drop it.
40 tasks
jrafanie
force-pushed
the
rename_ansible_tag_features_to_be_generic
branch
2 times, most recently
from
2f85e13 to
859f921
Compare
6 tasks
jrafanie
force-pushed
the
rename_ansible_tag_features_to_be_generic
branch
from
859f921 to
c19142b
Compare
jrafanie
force-pushed
the
rename_ansible_tag_features_to_be_generic
branch
from
c19142b to
0c22315
Compare
agrare
approved these changes
May 3, 2024
jrafanie
force-pushed
the
rename_ansible_tag_features_to_be_generic
branch
from
55b4b57 to
2cc2c07
Compare
|
Checked commits jrafanie/manageiq-ui-classic@94fcf9b~...2cc2c07 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/presenters/menu/default_menu.rb
|
|
Okay with the core PR merged spec:routes passes locally for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: ManageIQ/manageiq#22971
Merge together: