Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the product feature for automation manager tagging of repos and credentials #22971

Merged

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Apr 1, 2024

@jrafanie jrafanie requested review from agrare and bdunne as code owners April 1, 2024 17:59
@miq-bot miq-bot added the wip label Apr 1, 2024
@jrafanie jrafanie changed the title [WIP] Generalize the automation manager tagging of repos and credentials [WIP] Generalize the product feature for automation manager tagging of repos and credentials Apr 1, 2024
@jrafanie jrafanie force-pushed the rename_ansible_tag_features_to_be_generic branch from 3b526c6 to 810e769 Compare April 1, 2024 18:22
@agrare
Copy link
Member

agrare commented Apr 1, 2024

@jrafanie maybe not in scope for this but should we update the description also?
:description: Everything under Ansible

jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this pull request Apr 1, 2024
jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this pull request Apr 1, 2024
jrafanie added a commit to jrafanie/manageiq-schema that referenced this pull request Apr 1, 2024
@jrafanie jrafanie changed the title [WIP] Generalize the product feature for automation manager tagging of repos and credentials Generalize the product feature for automation manager tagging of repos and credentials Apr 1, 2024
@miq-bot miq-bot removed the wip label Apr 1, 2024
jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this pull request Apr 1, 2024
We started with embedded ansible but with the addition of embedded terraform,
it makes sense to generalize these common product features.

Related to ManageIQ/manageiq-providers-embedded_terraform#3
@jrafanie jrafanie force-pushed the rename_ansible_tag_features_to_be_generic branch from 810e769 to 2b03131 Compare May 2, 2024 15:23
jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this pull request May 2, 2024
jrafanie added a commit to jrafanie/manageiq-schema that referenced this pull request May 2, 2024
jrafanie added a commit to jrafanie/manageiq-providers-embedded_terraform that referenced this pull request May 2, 2024
jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this pull request May 2, 2024
@jrafanie jrafanie force-pushed the rename_ansible_tag_features_to_be_generic branch from 92d9b6b to 1dd5357 Compare May 2, 2024 20:12
@miq-bot
Copy link
Member

miq-bot commented May 2, 2024

Checked commits jrafanie/manageiq@2b03131~...1dd5357 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@jrafanie
Copy link
Member Author

jrafanie commented May 2, 2024

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request May 2, 2024
jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this pull request May 2, 2024
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this pull request May 8, 2024
@agrare agrare merged commit a099ba9 into ManageIQ:master May 8, 2024
8 checks passed
@jrafanie jrafanie deleted the rename_ansible_tag_features_to_be_generic branch May 8, 2024 17:57
liu-samuel pushed a commit to liu-samuel/manageiq-ui-classic that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants