-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize the product feature for automation manager tagging of repos and credentials #22971
Generalize the product feature for automation manager tagging of repos and credentials #22971
Conversation
3b526c6
to
810e769
Compare
@jrafanie maybe not in scope for this but should we update the description also? |
We started with embedded ansible but with the addition of embedded terraform, it makes sense to generalize these common product features. Related to ManageIQ/manageiq-providers-embedded_terraform#3
810e769
to
2b03131
Compare
These features are being renamed in: ManageIQ/manageiq#22971
92d9b6b
to
1dd5357
Compare
Checked commits jrafanie/manageiq@2b03131~...1dd5357 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
From Pull Request: ManageIQ/manageiq#22971
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We started with embedded ansible but with the addition of embedded terraform, it makes sense to generalize these common product features.
Related to ManageIQ/manageiq-providers-embedded_terraform#3
Related to: #22971
Merge together:
Followup work comments moved to #23005