-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
particle_diagnostics and build system upgrades #203
Open
stonecoldhughes
wants to merge
93
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce time collection is working
added bin_edge_0_angle and bin_edge_1_angle to all be example angles that might or might not be useful; n_bins_angle was set to 100 arbitrarily
actual work to append to the angle histogram still needs to be done, but will be less time-consuming with Tim tomorrow
was giving both n_bins_time and n_bins_angle to both time and angle histograms, instead of giving them independent sets of dimensions
comprehensive instructions
User hint to make sure to make an output directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this branch contains Alyssa's particle_diagnostics time_angle as well as a new interface to read gitrInput.cfg as simply a class with named ints in it. Also contains build system upgrades such as newer ubuntu and cuda base image, cuda support for wider range of cmake versions.