Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

particle_diagnostics and build system upgrades #203

Closed
wants to merge 93 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
eaefd29
changes to build dependencies after install test
Dec 12, 2023
15a42bc
updated circle example for tracking particle attributes
Dec 15, 2023
8db79cc
added reading of particle time histogram variables and generation of …
Dec 15, 2023
2fafd0f
example producing same results as postprocessing
Jan 8, 2024
da4af7e
added checks in geometry file to ensure input file for multiple surfa…
Jan 8, 2024
2890053
add particle_diagnostics to build system
Jan 10, 2024
e6da697
Update gitr.cpp with ANGLE particle diagnostics
hayes2419 Feb 13, 2024
7deb73f
Update gitrInput.cfg of circle example to include part diag angle inputs
hayes2419 Feb 13, 2024
f50a235
Update particle_diagnostics.h with angle inputs
hayes2419 Feb 13, 2024
ed7fd82
Update gitr.cpp to set ncDims and ncVars for ANGLE particle diagnostics
hayes2419 Feb 13, 2024
4d8c9a9
Update particle_diagnostics.cpp to initialize angle diagnostics
hayes2419 Feb 13, 2024
23afaa4
Update particle_diagnostics.cpp to include ANGLE histograms
hayes2419 Feb 14, 2024
291a7ef
Update Particles.h to include transitAngle field
hayes2419 Feb 14, 2024
6a95505
Update particle_diagnostics.cpp to fix typos
hayes2419 Feb 14, 2024
2d0ede5
Update particle_diagnostics.h to add in *_particle_angle_histogram
hayes2419 Feb 14, 2024
73875f8
fix typos in gitr.cpp
hayes2419 Feb 14, 2024
00112aa
Update particle_diagnostics.cpp to fix typo
hayes2419 Feb 14, 2024
8dacb78
Update gitr.cpp to fix problem with dims_part_hist
hayes2419 Feb 14, 2024
2d13a24
Update gitr.cpp to declare new dims varnames
hayes2419 Feb 14, 2024
88e7b71
Update gitr.cpp to add perpDist to history.nc
hayes2419 Feb 15, 2024
9d26620
Update gitr.cpp to replace perpDist with perpDistanceToSurface
hayes2419 Feb 15, 2024
e75f44e
Update gitr.cpp to declare perpDistanceToSurface varnames
hayes2419 Feb 15, 2024
74173ae
Update history.h to include perpDistanceToSurface
hayes2419 Feb 15, 2024
4056b39
Update history.h to fix typos
hayes2419 Feb 15, 2024
e47e729
Update history.h to add perpDistanceToSurface declaration
hayes2419 Feb 15, 2024
ad686ad
Update boris.cpp to update perpDistanceToSurface field of particle ob…
hayes2419 Feb 15, 2024
99ca116
Update boris.cpp hoping to fix typos
hayes2419 Feb 15, 2024
94e229b
Update boris.cpp to replace storing perp_dist with minDist
hayes2419 Feb 15, 2024
d3b6d3a
populate perpDistanceToSurface field of history.nc (hopefully)
hayes2419 Feb 15, 2024
bead7c7
Update particle_diagnostics.cpp to bin particles falling outside the …
hayes2419 Feb 16, 2024
fb28247
Update gitr.cpp to include pi constant from constants.h
hayes2419 Feb 19, 2024
d745b0e
Update particle_diagnostics.cpp to add log(angle) capability
hayes2419 Mar 5, 2024
8224429
Update particle_diagnostics.h to add log(angle) capability
hayes2419 Mar 5, 2024
e92849d
Update gitr.cpp to add log(angle) capability
hayes2419 Mar 5, 2024
84a0ade
Update particle_diagnostics.cpp to attempt to add behavior for times_…
hayes2419 Mar 5, 2024
bee427b
Update particle_diagnostics.h to add ; typo
hayes2419 Mar 5, 2024
dbf1dbe
Update particle_diagnostics.cpp to debug if/else syntax
hayes2419 Mar 5, 2024
dd67516
Update particle_diagnostics.cpp debug attempt 3
hayes2419 Mar 5, 2024
3edc9f1
Update particle_diagnostics.cpp printf debugging 1
hayes2419 Mar 12, 2024
84f6422
Update particle_diagnostics.cpp printf debugging 2
hayes2419 Mar 12, 2024
fcf8266
Update particle_diagnostics.cpp printf debug 3
hayes2419 Mar 12, 2024
4abc211
Update particle_diagnostics.cpp printf debug 4
hayes2419 Mar 12, 2024
599c981
Update gitr.cpp to add nSurfaces to particle_diagnostics
hayes2419 Mar 12, 2024
5d50e45
Update particle_diagnostics.cpp printf debug 4
hayes2419 Mar 12, 2024
312bb8c
Update particle_diagnostics.cpp add comma
hayes2419 Mar 12, 2024
d866434
Update particle_diagnostics.h to add nSurfaces declaration
hayes2419 Mar 12, 2024
caab79a
Update particle_diagnostics.h typo
hayes2419 Mar 12, 2024
f6f3d21
Update particle_diagnostics.h typo
hayes2419 Mar 12, 2024
864a09c
Update particle_diagnostics.cpp typo
hayes2419 Mar 12, 2024
a4bc155
Update particle_diagnostics.cpp remove printf debugging statements
hayes2419 Mar 12, 2024
8e822fa
Update particle_diagnostics.cpp to try to debug nP issue
hayes2419 Apr 4, 2024
51b3eac
Update particle_diagnostics.cpp to debug nP issue
hayes2419 Apr 4, 2024
4a14959
Update particle_diagnostics.cpp to set weight to 0 at the end of the …
hayes2419 Apr 5, 2024
96dcd5c
turn off print statement debugging because the error was that you got…
Apr 15, 2024
5e34cbe
begin debugging angle=0 when charge=1
Apr 19, 2024
e195292
deactivated file_io_tests, debug mode, cuda=1
Apr 24, 2024
ef0b16b
hopefully resolving merge conflict in noninteractive podman .sh bashfile
hayes2419 Jun 12, 2024
9d5b761
maintenance
hayes2419 Jun 14, 2024
9f11de2
Update particle_diagnostics.cpp to comment out debug print statement
hayes2419 Jun 14, 2024
9b52135
Update compile_time_options.cmake to build with Release mode by default
hayes2419 Jun 14, 2024
0e40660
new container files...
Jul 15, 2024
34e5555
add correct bash script for gpu interactive build using podman and re…
hayes2419 Jul 15, 2024
f597ed5
add volume lines to interactive podman build bash script
hayes2419 Jul 15, 2024
6852064
add untested noninteractive podman bash script
hayes2419 Jul 15, 2024
5b2c10e
fixed debug/cuda mode
Jul 15, 2024
167a8ac
add build.sh to .gitignore
hayes2419 Jul 15, 2024
81d9ae7
added cuda architectures, cpu/gpu working bare metal and containers
Jul 16, 2024
1ba5df2
added printouts for errors
Jul 19, 2024
555e55c
tried out a fix
Jul 19, 2024
24cb0b0
static cast lookup table values
Jul 19, 2024
818b568
explicitly set surface_model enumeration
Jul 19, 2024
129d881
print keys before and after
Jul 19, 2024
7a242d7
more printout statements
Jul 19, 2024
5bb851c
stop overwriting my build.sh files
hayes2419 Jul 19, 2024
9e7c2d7
added experimental flag to filesystem
Jul 19, 2024
fc6ead8
removed std::filesystem due to inconsistent support
Jul 19, 2024
0a6f46c
removed bloated config_interface from gitr.cpp
Jul 19, 2024
7d546fe
changed name of running container image
Jul 22, 2024
63362e7
added pictures back to repo
Aug 30, 2024
6fd0d29
Update README.md
stonecoldhughes Aug 30, 2024
c063020
Update README.md
stonecoldhughes Sep 25, 2024
0a7f63b
Update README.md
stonecoldhughes Sep 25, 2024
aab8556
Update README.md
stonecoldhughes Sep 26, 2024
e60ab9b
Update README.md
stonecoldhughes Sep 26, 2024
c453113
Update README.md
stonecoldhughes Sep 27, 2024
2807cb2
Update README.md
hayes2419 Sep 27, 2024
4e5760c
Update README.md
hayes2419 Sep 27, 2024
5d3cf15
fixed some errors
Nov 1, 2024
071eb35
Update README.md
stonecoldhughes Nov 1, 2024
58d29e7
output error if input directory not found; create output dir using
Nov 8, 2024
1355ea0
removing flags
Nov 8, 2024
b8fb5a6
removed breaking header
Nov 12, 2024
70a1bcf
reset default compile time options
hayes2419 Nov 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ external
.*.swp
test_include/test_data_filepath.hpp
**/output
*.sh
2 changes: 1 addition & 1 deletion CMake/compile_time_options.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ set( CMAKE_BUILD_TYPE "Release" )
# preprocessor definitions in source code are defined below:
set( description "(no description added yet)" )
set( GITR_USE_CUDA 0 CACHE STRING "${description}" FORCE )
set( GITR_USE_OPENMP 0 CACHE STRING "${description}" FORCE )
set( GITR_USE_OPENMP 1 CACHE STRING "${description}" FORCE )
set( GITR_USE_MPI 0 CACHE STRING "${description}" FORCE )
set( GITR_USE_DOUBLE 1 CACHE STRING "${description}" FORCE )

Expand Down
22 changes: 13 additions & 9 deletions CMake/crosslink_components.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ target_link_libraries( GITR
spectroscopy
libconfig_cxx
libconfig_c
particle_diagnostics
utils
boris
surface_model
Expand All @@ -95,6 +96,9 @@ if( GITR_USE_CUDA )

endforeach()

target_link_libraries( geometry_check atomic_add_1 )
target_link_libraries( spectroscopy atomic_add_1 )

endif()

if( GITR_USE_OPENMP )
Expand Down Expand Up @@ -158,15 +162,15 @@ target_link_libraries( coulomb_tests
Catch2::Catch2WithMain
)

target_link_libraries( file_io_tests
libconfig_cxx
libconfig_c
flags
utils
boris
geometry_check
Catch2::Catch2WithMain
)
#target_link_libraries( file_io_tests
# libconfig_cxx
# libconfig_c
# flags
# utils
# boris
# geometry_check
# Catch2::Catch2WithMain
# )

target_link_libraries( interpolator_tests Catch2::Catch2WithMain )

Expand Down
6 changes: 5 additions & 1 deletion CMake/cuda.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,8 @@ endif()

include_directories( ${CUDAToolkit_INCLUDE_DIRS} )

set( CMAKE_CUDA_ARCHITECTURES 70 )
if( CMAKE_MINOR_VERSION VERSION_LESS 25 )
set( CMAKE_CUDA_ARCHITECTURES 80 75 70 )
else()
set( CMAKE_CUDA_ARCHITECTURES native )
endif()
2 changes: 2 additions & 0 deletions CMake/define_source_components.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ set( non_gpu_targets

# conditionally compile as GPU targets
set( gpu_targets
particle_diagnostics
surface_model
interp2d
interpRateCoeff
Expand All @@ -39,6 +40,7 @@ set( gpu_targets
hashGeom
fields
spectroscopy
atomic_add_1
geometry_check )

set( gpu_broker_targets
Expand Down
2 changes: 1 addition & 1 deletion CMake/define_test_components.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ set( gpu_test_targets
cross_field_diffusion_tests
atomic_tests
coulomb_tests
file_io_tests
)
#file_io_tests

foreach( component IN LISTS cpu_test_targets )

Expand Down
8 changes: 8 additions & 0 deletions CMake/enforce_build_order.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,15 @@ if( dependencies )

endif()

add_dependencies( boris particle_diagnostics )
# ensure that all source targets are built before GITR
add_dependencies( GITR ${non_gpu_targets} ${gpu_targets} )

add_dependencies( boris_data_broker boris flags )

if( GITR_USE_CUDA )

add_dependencies( geometry_check atomic_add_1 )
add_dependencies( spectroscopy atomic_add_1 )

endif()
Loading
Loading