-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Add release notes v1.35.0 #22137
base: master
Are you sure you want to change the base?
[doc] Add release notes v1.35.0 #22137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel-bin/tools/release_engineering/relnotes --action=create --version=v1.35.0 --prior_version=v1.34.0
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel-bin/tools/release_engineering/relnotes --action=update --version=v1.35.0
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
doc/_release-notes/v1.35.0.md
line 4 at r1 (raw file):
title: Drake v1.35.0 date: 2099-12-31 released: YYYY-MM-DD
Set to Working. Remind myself to update the date when it's ready.
Code quote:
date: 2099-12-31
released: YYYY-MM-DD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 54 at r2 (raw file):
* Fix `GraphOfConvexSets` when passing in a trivially-infeasible upper bound ([#22090][_#22090]) ## Multibody Dynamics and Geometry
Multibody Dynamics and Geometry
is next. Working.
- Multibody Dynamics and Geometry - Miscellaneous features and fixes - pydrake bindings - Build system - Removal of deprecated items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 136 at r3 (raw file):
* [fix] TBD [workspace] Upgrade rules_rust to latest release 0.53.0 ([#22119][_#22119]) * [fix] TBD [workspace] Upgrade abseil_cpp_internal to latest commit ([#22118][_#22118]) * TBD
Next is "Build dependencies."
Code quote:
* [fix] TBD [workspace] Force-disable CoinUtils debugging hooks ([#22063][_#22063])
* [fix] TBD [workspace] Upgrade openusd_internal to latest release 24.11 ([#22082][_#22082])
* [fix] TBD [workspace] Upgrade drake_models to latest commit ([#22103][_#22103])
* [fix] TBD [workspace] Upgrade crate_universe to latest ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade dm_control_internal to latest release 1.0.24 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade msgpack_internal to latest release cpp-7.0.0 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade mujoco_menagerie_internal to latest commit ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade mypy_internal to latest release v1.13.0 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade statsjs to latest commit ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade suitesparse_internal to latest release v7.8.3 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade tinyobjloader_internal to latest commit ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade vtk_internal to latest commit ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade rules_rust to latest release 0.53.0 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade abseil_cpp_internal to latest commit ([#22118][_#22118])
* TBD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 136 at r3 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
Next is "Build dependencies."
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
-- commits
line 30 at r5:
I'm ready to do --action=update
again and merge upstream/master without rebase.
Code quote:
New commits in r5 on 11/12/2024 at 5:44 PM:
- 73b8c5e: Sort "Build system", "Build dependencies", "Removal of deprecated items"
- e90c69c: Fix typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
Previously, DamrongGuoy (Damrong Guoy) wrote…
I'm ready to do
--action=update
again and merge upstream/master without rebase.
Done.
- Mathematical Program - Multibody Dynamics and Geometry - Planning - Miscellaneous features and fixes - pydrake bindings - Build dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
doc/_release-notes/v1.35.0.md
line 4 at r1 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
Set to Working. Remind myself to update the date when it's ready.
We're on November 12 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-(status: do not review)
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2.
Reviewable status: 5 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
doc/_release-notes/v1.35.0.md
line 62 at r8 (raw file):
BTW I almost wonder if this didn't get the wrong tag. Technically, it expands public API (which is why it got the "feature" tag). However, explaining what that feature is is difficult.
Let's try this phrase:
Allow GeometryInstance to be registered through MultibodyPlant with clarifications on the related semantics
doc/_release-notes/v1.35.0.md
line 9 at r8 (raw file):
# Announcements * TBD
Also, don't forget to update these TBDs "None" before the final version.
doc/_release-notes/v1.35.0.md
line 118 at r8 (raw file):
<!-- <relnotes for cmake,doc,setup,third_party,tools go here> --> * Upgrade bazelisk to latest release v1.22.1 ([#22119][_#22119])
nit: In alphabetical order, bazelisk
would come after bazel
doc/_release-notes/v1.35.0.md
line 118 at r8 (raw file):
<!-- <relnotes for cmake,doc,setup,third_party,tools go here> --> * Upgrade bazelisk to latest release v1.22.1 ([#22119][_#22119])
nit: These "upgrade to latest..." lines all belong under the next block: "Build dependencies".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
doc/_release-notes/v1.35.0.md
line 151 at r8 (raw file):
* `drake::geometry::MeshcatVisualizer::ResetRealtimeRateCalculator()` ([#22086][_#22086]) * `drake::multibody::CalcSpatialInertia()` with the default density value ([#22086][_#22086])
Blocking until we merge #22166.
This change is