-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Generic Binding<Cost> and Binding<Constraint> to vertices and edges within a GcsTrajectoryOptimization::EdgesBetweenSubgraphs #22199
Conversation
…ded an invalid variable, instead of properly catching the bug. This fixes that bug, and updates the error message we check for.
…es within a GcsTrajectoryOptimization::Subgraph.
…opt-edgesbetweensubgraphs-bound-cost-constraint
Now that #22179 has gone to platform review, let's go ahead and start feature review here. +@RussTedrake, let's finish this chain of PRs off? |
…opt-edgesbetweensubgraphs-bound-cost-constraint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor request, otherwise
+@sammy-tri for platform review, please.
Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)
planning/trajectory_optimization/gcs_trajectory_optimization.h
line 759 at r2 (raw file):
kRestriction}); /** Convenience overload of AddEdgeCost to take in a Binding<Cost>. */
i think it's worth still mentioning here that the binding can only use the placeholder variables (since they enter slightly differently)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)
planning/trajectory_optimization/gcs_trajectory_optimization.h
line 759 at r2 (raw file):
Previously, RussTedrake (Russ Tedrake) wrote…
i think it's worth still mentioning here that the binding can only use the placeholder variables (since they enter slightly differently)
Done.
I also made the change to the analogous methods for Subgraph
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran out of time to get to this today, but I'll keep it assigned to me for platform review since I'm familiar (a bit) with the area from previous PRs. Sorry for the delay!
Reviewable status: LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees sammy-tri(platform),RussTedrake(platform)
…ges within a GcsTrajectoryOptimization::EdgesBetweenSubgraphs (RobotLocomotion#22199)
Closes #21981.
This PR builds off of #22179, so let's hold off on feature review until that lands. (I'll update this branch based on any changes made to that PR before it merges.)
This change is