Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Generic Binding<Cost> and Binding<Constraint> to vertices and edges within a GcsTrajectoryOptimization::EdgesBetweenSubgraphs #22199

Conversation

cohnt
Copy link
Contributor

@cohnt cohnt commented Nov 15, 2024

Closes #21981.

This PR builds off of #22179, so let's hold off on feature review until that lands. (I'll update this branch based on any changes made to that PR before it merges.)


This change is Reviewable

@cohnt
Copy link
Contributor Author

cohnt commented Nov 18, 2024

Now that #22179 has gone to platform review, let's go ahead and start feature review here.

+@RussTedrake, let's finish this chain of PRs off?

Copy link
Contributor

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor request, otherwise :lgtm:
+@sammy-tri for platform review, please.

Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)


planning/trajectory_optimization/gcs_trajectory_optimization.h line 759 at r2 (raw file):

                    kRestriction});

    /** Convenience overload of AddEdgeCost to take in a Binding<Cost>. */

i think it's worth still mentioning here that the binding can only use the placeholder variables (since they enter slightly differently)

Copy link
Contributor Author

@cohnt cohnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)


planning/trajectory_optimization/gcs_trajectory_optimization.h line 759 at r2 (raw file):

Previously, RussTedrake (Russ Tedrake) wrote…

i think it's worth still mentioning here that the binding can only use the placeholder variables (since they enter slightly differently)

Done.

I also made the change to the analogous methods for Subgraph.

Copy link
Contributor

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)

Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran out of time to get to this today, but I'll keep it assigned to me for platform review since I'm familiar (a bit) with the area from previous PRs. Sorry for the delay!

Reviewable status: LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)

@sammy-tri sammy-tri added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Dec 3, 2024
Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: +(status: squashing now)

Reviewed 3 of 5 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees sammy-tri(platform),RussTedrake(platform)

@sammy-tri sammy-tri merged commit 4b762d1 into RobotLocomotion:master Dec 3, 2024
10 checks passed
@cohnt cohnt deleted the gcstrajopt-edgesbetweensubgraphs-bound-cost-constraint branch December 3, 2024 20:54
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
…ges within a GcsTrajectoryOptimization::EdgesBetweenSubgraphs (RobotLocomotion#22199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: feature This pull request contains a new feature status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
Development

Successfully merging this pull request may close these issues.

Custom Costs and Constraints for GcsTrajectoryOptimization
3 participants