[workspace] Upgrade vtk_internal to latest commit #22597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove VTK patches that have been upstreamed.
BetsyMcPhail
force-pushed
the
upgrade-vtk
branch
from
e4a880a to
3f4b6bc
Compare
BetsyMcPhail
added
the
release notes: none
BetsyMcPhail
added
the
status: single reviewer ok
This was referenced Feb 6, 2025
Closed
BetsyMcPhail
added
release notes: fix
|
BTW When ready, we'll have @SeanCurtis-TRI do both reviews. |
rpoyner-tri
reviewed
Feb 11, 2025
There was a problem hiding this comment.
+@SeanCurtis-TRI for both reviews. Just getting this out of the "no one is assigned" list.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform), needs at least two assigned reviewers
|
This is not ready for review +(status: do not review) -@SeanCurtis-TRI. |
BetsyMcPhail
commented
Feb 14, 2025
There was a problem hiding this comment.
@sankhesh will investigate when he returns from vacation, the week of 2/25
Reviewable status: LGTM missing from assignee sankhesh, needs platform reviewer assigned, needs at least two assigned reviewers
|
Superseded by #22702. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove VTK patches that have been upstreamed.
Replaces #22565
Towards: #22536
This change is