feat: support inverting header matches for rate limit #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudrakhp
force-pushed
the
ratelimit_invert_match_headers
branch
2 times, most recently
from
b5feec5
to
bb18b2e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4286 +/- ##
=======================================
Coverage 65.71% 65.72%
=======================================
Files 200 200
Lines 24128 24141 +13
=======================================
+ Hits 15856 15866 +10
- Misses 7138 7139 +1
- Partials 1134 1136 +2 ☔ View full report in Codecov by Sentry. |
|
the PR looks good, can you add some tests in https://github.com/envoyproxy/gateway/tree/main/internal/gatewayapi/testdata & https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata |
rudrakhp
force-pushed
the
ratelimit_invert_match_headers
branch
6 times, most recently
from
5c4a215
to
059134c
Compare
arkodg
reviewed
Oct 1, 2024
rudrakhp
force-pushed
the
ratelimit_invert_match_headers
branch
4 times, most recently
from
c8357d4
to
e7f4310
Compare
arkodg
previously approved these changes
Oct 9, 2024
|
can you make linter happy? |
zhaohuabing
previously approved these changes
Oct 9, 2024
here are the errors |
Signed-off-by: Rudrakh Panigrahi <[email protected]>
rudrakhp
force-pushed
the
ratelimit_invert_match_headers
branch
from
e7f4310
to
5c645de
Compare
zhaohuabing
approved these changes
Oct 10, 2024
arkodg
approved these changes
Oct 10, 2024
This was referenced Oct 16, 2024
juwon8891
pushed a commit
to juwon8891/gateway
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Rudrakh Panigrahi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature changes for supporting inverting header matches for rate limiting.
What this PR does / why we need it:
Implements API changes proposed in #4176
Which issue(s) this PR fixes:
Ref #2193