Using a config file #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryukzak
force-pushed
the
aleksandr/config-2
branch
from
2c7a479 to
7a2993f
Compare
ryukzak
force-pushed
the
aleksandr/config-2
branch
from
7a2993f to
b27072a
Compare
nazrhom
reviewed
Apr 20, 2022
nazrhom
reviewed
Apr 20, 2022
|
@nazrhom Thank you for the review. |
ryukzak
force-pushed
the
aleksandr/config-2
branch
from
949ebfd to
95f4d90
Compare
|
Currently, CI was broken after migration to hercules due to access to the private repo. |
ryukzak
force-pushed
the
aleksandr/config-2
branch
3 times, most recently
from
abcd793 to
8bd1e42
Compare
szg251
reviewed
Apr 27, 2022
ryukzak
force-pushed
the
aleksandr/config-2
branch
from
8bd1e42 to
6993843
Compare
ryukzak
force-pushed
the
aleksandr/config-2
branch
from
52ba058 to
32d2aa6
Compare
added 4 commits
June 4, 2022 00:55
plutus-config right now is a closed source project, so this commit remove this dependency.
szg251
approved these changes
Jun 6, 2022
| Right _ -> loadPABConfig fn | ||
| | otherwise -> | ||
| return $ pparamsError pcProtocolParamsFile err | ||
| Right pcProtocolParams -> return $ Right conf {pcProtocolParams} |
There was a problem hiding this comment.
Created a new issue for protocol params handling. I think with Misha's node querying work, we could just query for the params each time (or store in memory): #112
mikekeke
reviewed
Jun 6, 2022
src/PlutusConfig/Ledger.hs
Outdated
| instance HasSpec SlotConfig where | ||
| anySpec = slotConfigSpec | ||
|
|
||
| slotConfigSpec :: ValueSpec SlotConfig |
There was a problem hiding this comment.
SlotConfig should not be required anymore. It was used for slot <-> time conversions before and was removed in #105
mikekeke
approved these changes
Jun 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased with external plutus-config library: