Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor coverage collection #424

Merged
merged 40 commits into from
Feb 13, 2025
Merged

Refactor coverage collection #424

merged 40 commits into from
Feb 13, 2025

Conversation

jordancarlin
Copy link
Member

@jordancarlin jordancarlin commented Feb 6, 2025 •
edited
Loading

Complete overhaul of functional coverage collection methodology:

  • Move riscvISACOV into main repo and remove submodule
  • Add integrated instruction decoder to drive the rest of the coverage collection
  • Lots of updates to functional coverage collection classes and functions to align more closely with cvw-arch-verif design
  • New extension selection methodology (using `defines instead of `includes)
  • Updates to variable lengths to ensure compatibility with RV32 and RV64
  • Updates to several coverpoints to align with new decoder/official spec
  • New .f file with file list for easy inclusion in simulation
  • Setup script to set appropriate paths for the .f file
  • Lots of other small changes

@jordancarlin
Merge branch 'main' of https://github.com/openhwgroup/cvw-arch-verif …
f7cf656 
…into coverage_refactor
@jordancarlin
Merge branch 'main' of https://github.com/openhwgroup/cvw-arch-verif …
c5f3c14 
…into coverage_refactor
@jordancarlin
Fix typo
61d0e17
@jordancarlin
Move coverage tracer
7462d7f
@jordancarlin
Use manifest file
a4e5b19
@jordancarlin
Relocate some files
67bfaba
@jordancarlin
Add support for floating point rounding modes to disassemble function
cbbade4
@jordancarlin
Merge branch 'main' of https://github.com/openhwgroup/cvw-arch-verif …
316355b 
…into coverage_refactor
@jordancarlin
Rename main coverage module
dbd1a65
@jordancarlin
Refactor disassembly registers
cc7469b
@jordancarlin
Add new get_csr_address function
0c82bcf
@jordancarlin
Complete CSR decoding
bbe82c6
@jordancarlin
Update coverpoints for compatibility with new coverage collection fun…
6ab4fae 
…ctions
@jordancarlin
More cleanup
3f71969
@jordancarlin
Full compressed support in decoder
91d36de
@jordancarlin jordancarlin marked this pull request as ready for review February 13, 2025 10:43
@jordancarlin
Copy link
Member Author

This should finally be ready to go! I'm getting identical coverage to the old methodology

@jordancarlin jordancarlin mentioned this pull request Feb 13, 2025
Merged
@davidharrishmc davidharrishmc merged commit c85de5e into openhwgroup:main Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordancarlin @davidharrishmc @Marina-Bellido