-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for yardstick fairness metrics #684
Conversation
could also skip tests conditionally on yardstick version
metrics_by <- get_metrics_by(metrics) | ||
if (length(metrics_by) > 0) { | ||
new_data$.row <- orig_rows | ||
res <- dplyr::full_join(res, new_data[c(metrics_by, ".row")], by = ".row") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is the un-preprocessed data column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incredible how few changes were needed in {tune}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🙌
The tests cover the kinds of situations (fairness metrics are vs. are not predictors) that I see people wanting to apply this with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question; otherwise looks great
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Related to tidymodels/yardstick#434!