Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for yardstick fairness metrics #684

Merged
merged 5 commits into from
Jun 26, 2023
Merged

add support for yardstick fairness metrics #684

merged 5 commits into from
Jun 26, 2023

Conversation

simonpcouch
Copy link
Contributor

@simonpcouch simonpcouch commented May 15, 2023

metrics_by <- get_metrics_by(metrics)
if (length(metrics_by) > 0) {
new_data$.row <- orig_rows
res <- dplyr::full_join(res, new_data[c(metrics_by, ".row")], by = ".row")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is the un-preprocessed data column.

Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible how few changes were needed in {tune}

Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌

The tests cover the kinds of situations (fairness metrics are vs. are not predictors) that I see people wanting to apply this with.

Copy link
Member

@topepo topepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question; otherwise looks great

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants