-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Expression Costs and Formula Constraints to EdgesBetweenSubgraphs in GcsTrajectoryOptimization #22155
Add Expression Costs and Formula Constraints to EdgesBetweenSubgraphs in GcsTrajectoryOptimization #22155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform)
planning/trajectory_optimization/test/gcs_trajectory_optimization_test.cc
line 2833 at r1 (raw file):
auto edge_durations = edges.edge_constituent_vertex_durations(); unused(kTol);
not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion
… in GcsTrajectoryOptimization.
433b6e8
to
4ffea57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, labeled "do not merge" (waiting on @cohnt)
planning/trajectory_optimization/test/gcs_trajectory_optimization_test.cc
line 2833 at r1 (raw file):
Previously, RussTedrake (Russ Tedrake) wrote…
not needed?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @RussTedrake from a discussion.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),RussTedrake(platform)
… in GcsTrajectoryOptimization. (RobotLocomotion#22155)
Towards #21981. Adds placeholder variables to EdgesBetweenSubgraphs that can be used to construct costs and constraints to each edge.
+@RussTedrake for feature review, please! cc @wrangelvid
This change is