Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expression Costs and Formula Constraints to EdgesBetweenSubgraphs in GcsTrajectoryOptimization #22155

Conversation

cohnt
Copy link
Contributor

@cohnt cohnt commented Nov 11, 2024

Towards #21981. Adds placeholder variables to EdgesBetweenSubgraphs that can be used to construct costs and constraints to each edge.

+@RussTedrake for feature review, please! cc @wrangelvid


This change is Reviewable

Copy link
Contributor

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

+@rpoyner-tri for platform review, please.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform)


planning/trajectory_optimization/test/gcs_trajectory_optimization_test.cc line 2833 at r1 (raw file):

  auto edge_durations = edges.edge_constituent_vertex_durations();

  unused(kTol);

not needed?

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion

@cohnt cohnt force-pushed the gcstrajopt-edgesbetweensubgraphs-costs-constraints branch from 433b6e8 to 4ffea57 Compare November 14, 2024 20:30
Copy link
Contributor Author

@cohnt cohnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, labeled "do not merge" (waiting on @cohnt)


planning/trajectory_optimization/test/gcs_trajectory_optimization_test.cc line 2833 at r1 (raw file):

Previously, RussTedrake (Russ Tedrake) wrote…

not needed?

Done.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion

Copy link
Contributor Author

@cohnt cohnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @RussTedrake from a discussion.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),RussTedrake(platform)

@cohnt cohnt merged commit 41c1a1b into RobotLocomotion:master Nov 14, 2024
8 of 9 checks passed
@cohnt cohnt deleted the gcstrajopt-edgesbetweensubgraphs-costs-constraints branch November 14, 2024 21:47
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: feature This pull request contains a new feature
Projects
Development

Successfully merging this pull request may close these issues.

3 participants